Use checkpoint pagination to get all organizations

auth0 / auth0-deploy-cli

The Auth0 Deploy CLI is a tool that helps you manage your Auth0 tenant configuration. It integrates into your development workflows as a standalone CLI or as a node module.

MIT License

248 stars 155 forks source link

Use checkpoint pagination to get all organizations #984

Closed tc3-iwakura closed 2 days ago

tc3-iwakura commented 1 week ago

🔧 Changes

This updates the way to get all organizations. It enables to export more than 1000 organizations by using checkpoint pagination.

📚 References

related changes

🔬 Testing

related existing test

https://github.com/auth0/auth0-deploy-cli/blob/c0e372f9e52565914a6d743154d84a967fe50086/test/tools/auth0/handlers/organizations.tests.js

📝 Checklist

[x] All new/changed/fixed functionality is covered by tests (or N/A)
(N/A) I have added documentation for all new/changed functionality (or N/A)

kushalshit27 commented 3 days ago

Hi, @tc3-iwakura Thank you for submitting this PR! I appreciate the time and effort you put into it and your approach to tackling this issue. The code looks good overall.

I will check the failing E2E test and merge it soon. Thanks again.

kushalshit27 commented 3 days ago

Hi, @tc3-iwakura I have updated the recordings on https://github.com/tc3-japan/auth0-deploy-cli/pull/1 Please merge it to update this PR

tc3-iwakura commented 3 days ago

Hi, @kushalshit27 . Thank you for updating recordings. I found lockdown e2e test will be successful if add AUTH0_E2E_CLIENT_ID=Vp0gMRF8PtMzekil38qWoj4Fjw2VjRZE to the below CI command, but it may be better to add the key-value to Circle CI environment. Could you please tell me which is better or another way?

https://github.com/auth0/auth0-deploy-cli/blob/c0e372f9e52565914a6d743154d84a967fe50086/.circleci/config.yml#L14

related code

kushalshit27 commented 2 days ago

Hi, @tc3-iwakura We will release it soon, along with other items, by the end of this week.

Thank you again for submitting this PR!