auth0 / auth0-flutter

Auth0 SDK for Flutter
https://pub.dev/documentation/auth0_flutter/latest/
Apache License 2.0
57 stars 37 forks source link

Fix publish workflow #339

Closed Widcket closed 8 months ago

Widcket commented 8 months ago

📋 Changes

This PR fixes the CI publish workflow, as it was failing because the dart-lang/setup-dart/.github/workflows/publish.yml@v1 action installs dependencies using dart pub get, but our packages depend on Flutter, and as such need to use flutter pub get instead:

Screenshot 2023-11-08 at 16 41 53

But still the Dart SDK needs to be installed using that action, as it contains the logic necessary for getting the token used for publishing.

Unlike that action, we're not adding a dry run step because it returns a non-zero error code (that fails the workflow) when there are warnings, and the auth0_flutter package produces warnings:

Screenshot 2023-11-08 at 17 20 54

We won't be fixing the warning marked with red; the scenario the warning is about does not apply for auth0_flutter, which will always depend on a specific version of auth0_flutter_platform_interface.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (253209a) 96.08% compared to head (980ed82) 95.80%. Report is 22 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #339 +/- ## ============================================ - Coverage 96.08% 95.80% -0.29% ============================================ Files 97 76 -21 Lines 1611 1121 -490 Branches 331 281 -50 ============================================ - Hits 1548 1074 -474 + Misses 49 46 -3 + Partials 14 1 -13 ``` | [Flag](https://app.codecov.io/gh/auth0/auth0-flutter/pull/339/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0) | Coverage Δ | | |---|---|---| | [auth0_flutter](https://app.codecov.io/gh/auth0/auth0-flutter/pull/339/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0) | `100.00% <100.00%> (ø)` | | | [auth0_flutter_android](https://app.codecov.io/gh/auth0/auth0-flutter/pull/339/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0) | `?` | | | [auth0_flutter_ios](https://app.codecov.io/gh/auth0/auth0-flutter/pull/339/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0) | `?` | | | [auth0_flutter_platform_interface](https://app.codecov.io/gh/auth0/auth0-flutter/pull/339/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0) | `87.03% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/auth0/auth0-flutter/pull/339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0) | Coverage Δ | | |---|---|---| | [...lib/src/web/extensions/user\_profile\_extension.dart](https://app.codecov.io/gh/auth0/auth0-flutter/pull/339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0#diff-YXV0aDBfZmx1dHRlci9saWIvc3JjL3dlYi9leHRlbnNpb25zL3VzZXJfcHJvZmlsZV9leHRlbnNpb24uZGFydA==) | `100.00% <100.00%> (ø)` | | | [...lutter\_platform\_interface/lib/src/credentials.dart](https://app.codecov.io/gh/auth0/auth0-flutter/pull/339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0#diff-YXV0aDBfZmx1dHRlcl9wbGF0Zm9ybV9pbnRlcmZhY2UvbGliL3NyYy9jcmVkZW50aWFscy5kYXJ0) | `100.00% <100.00%> (ø)` | | ... and [23 files with indirect coverage changes](https://app.codecov.io/gh/auth0/auth0-flutter/pull/339/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.