search

auth0 / auth0-flutter

Auth0 SDK for Flutter
https://pub.dev/documentation/auth0_flutter/latest/
Apache License 2.0
59 stars 41 forks source link

af: Gate native unit tests code per platform [SDK-4701] 3/3 #349

Closed Widcket closed 10 months ago

Widcket commented 10 months ago

📋 Changes

This PR gates all the native Swift unit tests in auth0_flutter behind compile-time conditionals, so it compiles correctly on both platforms.

Also, a leftover compile-time check for iOS < 13 was removed from a mock, now that the SDK no longer supports iOS 12.

Widcket commented 10 months ago

The flutter analyze CI check (CI / Analyze auth0_flutter_platform_interface Flutter package) will pass once https://github.com/auth0/auth0-flutter/pull/347 gets merged.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (macos-support/native-code-gating@bb1bfbf). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## macos-support/native-code-gating #349 +/- ## =================================================================== Coverage ? 96.36% =================================================================== Files ? 98 Lines ? 1596 Branches ? 328 =================================================================== Hits ? 1538 Misses ? 50 Partials ? 8 ``` | [Flag](https://app.codecov.io/gh/auth0/auth0-flutter/pull/349/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0) | Coverage Δ | | |---|---|---| | [auth0_flutter](https://app.codecov.io/gh/auth0/auth0-flutter/pull/349/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0) | `100.00% <0.00%> (?)` | | | [auth0_flutter_android](https://app.codecov.io/gh/auth0/auth0-flutter/pull/349/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0) | `97.35% <0.00%> (?)` | | | [auth0_flutter_ios](https://app.codecov.io/gh/auth0/auth0-flutter/pull/349/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0) | `99.85% <0.00%> (?)` | | | [auth0_flutter_platform_interface](https://app.codecov.io/gh/auth0/auth0-flutter/pull/349/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0) | `87.03% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.