auth0 / auth0-java-mvc-common

Contains common helper classes and api client logic that are used across our Java MVC libraries
MIT License
43 stars 39 forks source link

Directly Support Jakarta 9.1 #97

Closed gesker closed 2 years ago

gesker commented 3 years ago

Describe the problem you'd like to have solved

Could this library be updated to support Jakarta 9.1 and pending version 10?

Describe the ideal solution

Would like to use the buildAuthorizeUrl method without having to cast jakarta.servlet.http.HttpServletRequest to javax.servlet.http.HttpServletRequest and jakarta.servlet.http.HttpServletResponse to javax.servlet.http.HttpServletResponse.

Alternatives and current work-arounds

Currently manually importing/loading the javax.servlet jar into Glassfish 6.2.2 container so that the old namespace is on the classpath of my application.

jimmyjames commented 2 years ago

Hi @gesker, thanks for raising. I'm not sure if there's a way to better support Jakarta 9+ directly without introducing a breaking change, but will have to spend some time looking into that. I'm going to be on holiday for the next week, but will try and budget some time to look into this on my return, or at the very least raise as a candidate for a new major release. Thanks again!

gesker commented 2 years ago

Thanks @jimmyjames I very much appreciate your considering this request.

One idea that occurred to me as I began trying to use your library, and that I thought I might run past you, which would make Auth0 integration into a Jakarta application super quick and very cool would be if this library could play off of the Jakarta Security API and produce/provide annotations that could be utilized akin to DatabaseIdentityStoreDefinition & CustomFormAuthenticationMechanismDefinition -- perhaps something like Auth0IdentityStoreDefintion & Auth0FormAuthenticationMechanismDefinition, Auth0RememberMe, etc. -- which could be dropped into an ApplicationScoped bean.

Pivoting off of the Jakarta Security API would make tying an application to and using Auth0 painless - just match the parameters entered on the website and the paramaters on the annotations - and integration could be accomplished in minutes.

Let me know if you think this idea has merit. In any event... thanks again for considering my initial request.

Have a safe and fun holiday!

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

uap-universe commented 2 years ago

Jakarta EE was released more than two years ago - this library should be compatible or at least a compatible alternative should be available.

cromat commented 2 weeks ago

I have created a converter library for this purpose: jakarta2javax.