Closed gitwouter closed 10 months ago
adamjmcgrath
commented
10 months ago Hi @gitwouter - thanks for raising this, created #546 to fix
auth0-python version 4.5.0
Out of curiosity - how are you using the types? My understanding is we're not publishing them since https://github.com/auth0/auth0-python/pull/521
gitwouter
commented
10 months ago Hello Adam,
I just use python type checking in vscode. (Microsoft Black Formatter v2023.4.1 )
Best regards, Wouter
From: Adam Mcgrath @.> Date: Tuesday, 31 October 2023 at 13:50 To: auth0/auth0-python @.> Cc: Wouter Denayer @.>, Mention @.> Subject: Re: [auth0/auth0-python] typing in roles.py (Issue #545)
Hi @gitwouterhttps://github.com/gitwouter - thanks for raising this, created #546https://github.com/auth0/auth0-python/pull/546 to fix
auth0-python version 4.5.0
Out of curiosity - how are you using the types? My understanding is we're not publishing them since #521https://github.com/auth0/auth0-python/pull/521
— Reply to this email directly, view it on GitHubhttps://github.com/auth0/auth0-python/issues/545#issuecomment-1787158151, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADEK4ANDQZBT3T2A32X7YR3YCDX3DAVCNFSM6AAAAAA6XKOFDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXGE2TQMJVGE. You are receiving this because you were mentioned.Message ID: @.***>
Checklist
Description
in roles.py
def remove_permissions(self, id: str, permissions: List[str]) -> Any: def add_permissions(self, id: str, permissions: List[str]) -> dict[str, Any]:
type annotation should be
permissions: List[dict[str, str]]
Reproduction
this is a development time type checking problem
Additional context
No response
auth0-python version
4.5.0
Python version
3.11