auth0 / auth0-vue

Auth0 authentication SDK for Vue.js apps
Other
140 stars 27 forks source link

Routes not awaited #388

Open illegalnumbers opened 8 months ago

illegalnumbers commented 8 months ago

Checklist

Description

Route calls, such as this https://github.com/auth0/auth0-vue/blob/efe1d39a0244fd072a527df97f87ab355501851d/src/plugin.ts#L185 and https://github.com/auth0/auth0-vue/blob/efe1d39a0244fd072a527df97f87ab355501851d/src/plugin.ts#L171, should be awaited as they are async.

Reproduction

Code is not awaited

Additional context

No response

auth0-vue version

latest master

Vue version

any

Which browsers have you tested in?

Chrome

frederikprijck commented 8 months ago

Thanks for reaching out. The Vue Router docs is also very explicit about not awaiting this in the basic use-case, see: https://router.vuejs.org/guide/essentials/navigation.html. That said, they do have a section to call out the possibility to await route changes, see: https://router.vuejs.org/guide/advanced/navigation-failures.html

Can you help us understand what the problem is you are facing that would be solved by awaiting this?

Thanks.