auth0 / auth0.net

.NET client for the Auth0 Authentication & Management APIs.
https://auth0.com
MIT License
328 stars 163 forks source link

Add show_as_button to organizations connection #706

Closed jpealing-fiscaltec closed 7 months ago

jpealing-fiscaltec commented 7 months ago

Changes

Adds show_as_button to OrganizationConnection, OrganizationConnectionCreateRequest and OrganizationConnectionUpdateRequest.

References

This property is documented here:

Testing

I have attempted to add a unit test by following the pattern used for AssignMembershipOnLogin, however I was not able to run the tests to validate that they passed.

Checklist

frederikprijck commented 7 months ago

Thanks 👍 Ignore the failing CI, will look into it. PR looks good 🙏 🔥

jpealing-fiscaltec commented 7 months ago

Any update on when this is likely to be merged?

frederikprijck commented 7 months ago

Sorry, lost track of this. Let me fix CI and look into merging and releasing this.

frederikprijck commented 7 months ago

Tests are failing because the property is only supported for Enterprise Connections. I will revert the changes to the test and move forward without the tests, testing enterprise-only features are not always that trivial.