Closed landitus closed 1 year ago
If possible I'd change size={3}
on Headings for type={3}
.
We should not encourage authors to think about sizes but the hierarchy of header they want to use.
Here is a good example of a content component: https://bulma.io/documentation/elements/content/
Nitpick: Do we have a whitelist of components that goes inside Content? I see Image is used, not sure if it fits the definition
Use a Content when creating an area of text. Wrap other typography components to create a good vertical rhythm.
Real question: How does a developer make the decision what goes inside a content vs what doesn't. Is it the spacing / indentation / type of component?
Example - There are multiple ways of slicing a UI into contents:
(big picture, click to zoom)
Do we have a whitelist of components that go inside Content? I see Image is used, not sure if it fits the definition
👍 yeap! that'd be ideal
I'll add another example of a content component for reference
https://polaris.shopify.com/components/titles-and-text/text-container#navigation
Do we have a whitelist of components that go inside Content? I see Image is used, not sure if it fits the definition
👍 yeap! that'd be ideal
@landitus Can you add the whitelist here? Let's close the spec before we jump into implementation
If we are going to remove margins on v1, I think it's good timing to do this component.
Indeed!
Use a Content when creating an area of text. Wrap other typography components to create a good vertical rhythm.
Usage:
Example:
Note: to use a proper List, we need to change the name of the List component (which is a simple Table)