auth0 / express-jwt

connect/express middleware that validates a JsonWebToken (JWT) and set the req.user with the attributes
MIT License
4.49k stars 444 forks source link

Fix: await async jwt.verify function #320

Closed glensc closed 1 year ago

glensc commented 1 year ago

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

This looks like bug, to be able to try/catch exception from async function, it must be awaited.

Checklist

glensc commented 1 year ago

The correct base branch is being used, if not the default branch

unclear what this refers to. git branch? I see only master, also no contributing.md in this repo and the org wide file doesn't have details either.

jfromaniello commented 1 year ago

Make sense, published as v8.4.1

glensc commented 1 year ago

Wow. that was fast!

Can you also do (in that order):

glensc commented 1 year ago

Changelog not updated: