auth0 / java-jwt

Java implementation of JSON Web Token (JWT)
MIT License
5.91k stars 926 forks source link

Enable Jackson Afterburner Module for JWTCreator and JWTParser #669

Closed adam-gray closed 1 year ago

adam-gray commented 1 year ago

Changes

Please describe both what is changing and why this is important. Include:

References

Please include relevant links supporting this change such as a:

What is optimized using Jackson Afterburner? (copied from here) Following things are optimized:

... and what is not?

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Checklist

jimmyjames commented 1 year ago

Thanks @adam-gray for the PR! Im out of the office until next week, but will take a look when I return. One thing I'll be curious about is the ongoing activity/support for Afterburner, given the notes regarding a potential replacement in the works.

jimmyjames commented 1 year ago

The JWTDecoderTest is failing with this change, which I've reproduced locally. @adam-gray if you have any insight into the failure and potential fix we can advance this change.

jimmyjames commented 1 year ago

Closing this PR as it has gone inactive, but I do think this (and further potential customization of the ObjectMapper) is something we should consider. It's likely something that will be considered in the new year.

adam-gray commented 10 months ago

sorry for ghosting @jimmyjames - had a real busy period with work and then took some time to travel to see extended family over the holidays. when i get a chance i'll fix the test and resubmit 😃