Closed adam-gray closed 1 year ago
Thanks @adam-gray for the PR! Im out of the office until next week, but will take a look when I return. One thing I'll be curious about is the ongoing activity/support for Afterburner, given the notes regarding a potential replacement in the works.
The JWTDecoderTest
is failing with this change, which I've reproduced locally. @adam-gray if you have any insight into the failure and potential fix we can advance this change.
Closing this PR as it has gone inactive, but I do think this (and further potential customization of the ObjectMapper) is something we should consider. It's likely something that will be considered in the new year.
sorry for ghosting @jimmyjames - had a real busy period with work and then took some time to travel to see extended family over the holidays. when i get a chance i'll fix the test and resubmit 😃
Changes
Please describe both what is changing and why this is important. Include:
com.fasterxml.jackson.module:jackson-module-afterburner
with the existingjackson-databind
version of2.14.2
ObjectMapper
inJWTCreator
andJWTParser
classes to include theAfterburnerModule
References
Please include relevant links supporting this change such as a:
What is optimized using Jackson Afterburner? (copied from here) Following things are optimized:
int
,long
, String) are replaced with direct calls, instead of getting delegated toJsonSerializer
sint
,long
, String) are replaced with direct calls, instead of getting delegated toJsonDeserializer
s... and what is not?
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist