Code refactor - Githubissues

auth0 / java-jwt

Java implementation of JSON Web Token (JWT)

MIT License

5.84k stars 921 forks source link

Code refactor #678

Closed heramb99 closed 9 months ago

heramb99 commented 9 months ago

Solved Implementation and Design Smells

Implementation Smells

PayloadDeserializer Class-> getStringOrArray -> Resolve complex condition smell
ECDSAAlgorithm Class-> validateSignatureStructure -> Removed duplicate code by extracting method
ClaimsSerializer Class-> dateToSeconds -> introduce explain variable

Design Smells

HeaderParams Class -> Converted class to enum to solve Unnecessary Abstraction smell
KeyProvider Interface-> Pulled up getPrivateKeyId() inside interface to avoid duplicate code
Algorithm Class -> Extracted the method inside Algorithm class to solve Cyclic Hierarchy smell