auth0 / jupiterone-python-sdk

A Python client for jupiterone.io
MIT License
10 stars 17 forks source link

Use cursor pagination by default #11

Closed tywalch closed 2 years ago

tywalch commented 2 years ago

Description

The client currently uses LIMIT and SKIP conventions to paginate results. The latest convention uses a returned cursor to paginate through result sets instead. This should increase the overall speed of pagination for large result sets.

I took a non-breaking approach to this update. If the user does not supply limit or skip parameters then the new cursor functionality will be used.

Please let me know if I missed any requirements or expectations for this PR, thank you!

Testing

[x] This change adds test coverage for new/changed/fixed functionality

I have added tests and modified existing tests to differentiate between the two potential code flows: pagination with limit and skip and cursors. This has also been verified against the real J1 backend.

Checklist