By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Changes improve the error handling of requests being sent to JupiterOne.
Prior to these changes, if a 401 was the response code, the call to json.loads failed because the body does not contain JSON. This was hiding the real error from the user.
Testing
To test, call J1 with the client using an invalid token.
[X] This change adds test coverage for new/changed/fixed functionality
Checklist
[ ] I have added documentation for new/changed functionality in this PR or in auth0.com/docs
[ ] All active GitHub checks for tests, formatting, and security are passing
[ ] The correct base branch is being used, if not the default branch
VDubber
commented
1 year ago
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Changes improve the error handling of requests being sent to JupiterOne. Prior to these changes, if a 401 was the response code, the call to
json.loadsfailed because the body does not contain JSON. This was hiding the real error from the user.Testing
To test, call J1 with the client using an invalid token.
Checklist