auth0 / laravel-auth0

Laravel SDK for Auth0 Authentication and Management APIs.
MIT License
246 stars 135 forks source link

[SDK-4337] fix: Trim quote characters from around environment variable strings #409

Closed evansims closed 1 year ago

evansims commented 1 year ago

Changes

This PR resolves an issue where quote characters (', or ") are not removed from strings when pulling values from dotenv files. Although these quotes are always optional, it is common practice to use them. This was previous behavior before the 7.7 configuration system improvements.

References

Closes #399

Testing

Testing remains at 100%.

Contributor Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (41ca3d6) 100.00% compared to head (b0e8832) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #409 +/- ## =========================================== Coverage 100.00% 100.00% - Complexity 496 497 +1 =========================================== Files 31 31 Lines 1271 1274 +3 =========================================== + Hits 1271 1274 +3 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `100.00% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/auth0/laravel-auth0/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0) | Coverage Δ | | |---|---|---| | [src/Configuration.php](https://app.codecov.io/gh/auth0/laravel-auth0/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0#diff-c3JjL0NvbmZpZ3VyYXRpb24ucGhw) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.