feat: add `Illuminate\Support\Traits\Macroable` trait to Guards

auth0 / laravel-auth0

Laravel SDK for Auth0 Authentication and Management APIs.

MIT License

246 stars 132 forks source link

feat: add `Illuminate\Support\Traits\Macroable` trait to Guards #456

Open jose123v opened 4 months ago

jose123v commented 4 months ago

Checklist

[X] I agree to uphold the Code of Conduct.

Description

Illuminate/Auth/RequestGuard.php#L8C5-L12 Illuminate/Auth/SessionGuard.php#L30-L32 Guards/TokenGuard.php#L28-L30

Laravel uses Macroable class on the guards, why not here too?

Shouldn't it maintain consistency?

evansims commented 3 months ago

Thanks for your feature suggestion, @jose123v! I think that makes sense, and I see no issue with adding support for that. If there are any volunteers, this would be a great first issue for someone to take!