auth0 / lock

Auth0's signin solution
https://auth0.com/docs/libraries/lock
Other
1.13k stars 556 forks source link

Improve labels of social buttons #2459

Closed stevenbdf closed 1 year ago

stevenbdf commented 1 year ago

Checklist

Description

Problem In my company, we have developed a website and a mobile application. We use Auth0 in both to authenticate users. On the websites, users can sign up and login to their accounts. On the other hand, in the mobile app, users can only sign in not sign up. We use social connections only: Facebook, Google, Apple.

When using the universal login page in the mobile app via the RN Auth0 SDK, we found that the social button render the "Sign up with ..." string. As mentioned, in the mobile app we only want people to login. So, I went to the Universal Login Page Settings in the dashboard and tried to use the allowSignUp: false property that is described in the docs. After testing many times, looking at the codebase and reading entries in the Auth0 Community I realized that this option among with others like (allowLogin, allowForgotPassword and initialScreen) have absolutely no effect in the Social Buttons.

This is important because when one wants to submit a mobile application for review, the app marketplaces (Apple or Google) can complain that the "login" string actually says "sign up".

Temporary solution Override the signUpWithLabel and signUpTerms properties to correctly display "Sign in with ..."

Expected behavior As learned from the replies in the Auth0 community there's no big difference between a social login and sign up. So the request is to:

  1. Update the documentation to describe that these options have no effect to social buttons
  2. Replace loginWithLabel and signUpWithLabel dictionary keywords with "continueWithLabel" and make "Continue with" the default text, this indicates people could either sign up or login and we let social provider handle that situation

Reproduction

  1. Create social connections in Auth0 Dashboard
  2. Enable Universal Login
  3. Disable email and password, only allow social connection on Universal Login
  4. Try to use allowSignup and allowLogin configuration options

Additional context

No response

Lock version

12.2.0

Which browsers have you tested in?

Other

stevenbdf commented 1 year ago

Auth0 Community entries that talk about this topic:

frederikprijck commented 1 year ago

Thanks for reaching out. To verify, are you talking about the labels used at the signup tab?

That tab does show 'Signup with ...' for social connections for me. However, when I set allowSignUp to false (Note, it's allowSignUp, and not allowSignup as you mention above in the reproduction steps), the signup tab no longer shows and I do not see the buttons in question.

frederikprijck commented 1 year ago

Closing due to no activity. Ping me if u want to reopen.