search

auth0 / lock

Auth0's signin solution
https://auth0.com/docs/libraries/lock
Other
1.13k stars 557 forks source link

Show alert if no callbackURL is defined and a callback is set #5

Closed mgonto closed 10 years ago

mgonto commented 10 years ago

Right now, we show the World Domination message when the callback is missing and the user is trying a Social IdP. However, if the user tries to do a regular Username/Password Auth, a CORS error is thrown.

We should parse the s3 information to see if theres a callbackURL. If there's not and no callback is set to handle the success of the login, then we should show a message sayingPlease add currentURL as a CallbackURL on your application settings`.

Thanks!

cristiandouce commented 10 years ago

Is this an auth0/lock error or an auth0/widget error? could you check if it behaves the same here? I made several tweaks to the options handling and callbacks and stuff.. and there is algo more coming. :dancer:

mgonto commented 10 years ago

This didn't exist in auth0/widget nor anywhere before. I think it actually makes sense to show this error on auth0.js now that you mention this :).

I'll move the issue

cristiandouce commented 10 years ago

Cool!