Field 'enabled_clients' is not included in the Connection definition

auth0 / node-auth0

Node.js client library for the Auth0 platform.

MIT License

628 stars 307 forks source link

Field 'enabled_clients' is not included in the Connection definition #945

Closed jkillian-psc closed 2 months ago

jkillian-psc commented 11 months ago

Checklist

[X] I have looked into the Readme, Examples, and FAQ and have not found a suitable solution or answer.
[X] I have looked into the API documentation and have not found a suitable solution or answer.
[X] I have searched the issues and have not found a suitable solution or answer.
[X] I have searched the Auth0 Community forums and have not found a suitable solution or answer.
[X] I agree to the terms within the Auth0 Code of Conduct.

Description

Connection interface is missing enabled_clients field that is included in the response. The Management client API documentation for the operation (https://auth0.com/docs/api/management/v2/connections/get-connections-by-id) also makes no mention of the field either.

Reproduction

Initialize the Auth0 Management API client using library
Call the get( ) method on the ConnectionsManager
Print the result returned from the method

Additional context

No response

node-auth0 version

4.0.1

Node.js version

18.16.1

frederikprijck commented 11 months ago

Thanks for adding an issue, I am looking into this and will report back when I have more info. For the time being, you might want to unblock yourself typewise with some unfortunate casting or manual typing.

CooperBills commented 11 months ago

FWIW, we're also updating our client from an older version to 4.0.1 and we noticed this field is missing from the newer typings as well.

I see it's still in the actual object though, so we'll unblock with some manual typing & sanity checks, but I'm chiming in here to note @jkillian-psc isn't the only one seeing this.

frederikprijck commented 11 months ago

Thanks for that @CooperBills , yeah i have confirmed this with other teams and working on getting this fixed.

Gentracker1 commented 6 months ago

Hi, We are on 4.3.1 and we used to update the connection. Is there any other way to check the enabled clients? Our code is in production and we want to upgrade to the latest version. Thanks

tgillitzer commented 6 months ago

@frederikprijck Any timeline on getting this fixed? It makes it pretty hard to update a connection's enabled clients if you can't get the ones that are already enabled.

shawnb-gv commented 6 months ago

The only temp workaround I've found is to do something like connections["enabled_clients"] rather than connections.enabled_clients which throws the type error.

icco commented 3 months ago

I have created #1009 to fix this, as I filed a support ticket and they said they were not planning on prioritizing a fix.

frederikprijck commented 3 months ago

@icco We provided the support team with a (very ugly) workaround to unblock you immediately, while we acknowledged the need to have this fixed and the team is looking in fixing this properly so you no longer need such workaround, but because there is a (very ugly) workaround, a few other things have higher priority. But that does not mean this isn't going to be looked at.

Apologies this issue went stale tho, it kinda got lost from our radar, but you did help bring it back to our attention, thank you for that.

gyaneshgouraw-okta commented 2 months ago

Fix for this issue is released in https://www.npmjs.com/package/auth0/v/4.6.0