auth0 / node-jsonwebtoken

JsonWebToken implementation for node.js http://self-issued.info/docs/draft-ietf-oauth-json-web-token.html
MIT License
17.73k stars 1.23k forks source link

allowInsecureKeySizes flag not present among TS types. #969

Open toabm opened 6 months ago

toabm commented 6 months ago

Description

I updated from version 8 to 9, and since my RSA keys were not long enough I got the error: "secretOrPrivateKey has a minimum key size of 2048 bits for RS256"

I do not want to change all RSA keys in every environment so I decided to use the flag allowInsecureKeySizes to bypass that new check.

My project is buillt with typescript and if I use that flag with in the options of jwt.sign() method I will see this error:

"TS2769: No overload matches this cal"

Reproduction

jwt.sign({}, privateKey, { issuer: 'streetcrowd', subject: provider, algorithm: 'RS256', allowInsecureKeySizes: true });

This is the definition of SignOptions, as you can see, the required flag is missing:

export interface SignOptions { algorithm?: Algorithm | undefined; keyid?: string | undefined; expiresIn?: string | number | undefined; notBefore?: string | number | undefined; audience?: string | string[] | undefined; subject?: string | undefined; issuer?: string | undefined; jwtid?: string | undefined; mutatePayload?: boolean | undefined; noTimestamp?: boolean | undefined; header?: JwtHeader | undefined; encoding?: string | undefined; }

image

Environment

ankit-orion commented 2 months ago

The error you're encountering (TS2769: No overload matches this call) occurs because the allowInsecureKeySizes option is not part of the SignOptions interface provided by the jsonwebtoken package. This option isn't officially supported in the TypeScript typings for the library, which causes TypeScript to throw an error when you attempt to use it.

Workaround To bypass this TypeScript error, you can extend the SignOptions interface to include the allowInsecureKeySizes flag or use a type assertion to inform TypeScript that the object being passed is compatible.

`import jwt, { SignOptions } from 'jsonwebtoken';

// Extend the SignOptions to add allowInsecureKeySizes interface CustomSignOptions extends SignOptions { allowInsecureKeySizes?: boolean; }

// Use the extended interface with the additional option const token = jwt.sign({}, privateKey, { issuer: 'streetcrowd', subject: provider, algorithm: 'RS256', allowInsecureKeySizes: true, // Now TypeScript won't complain } as CustomSignOptions); `