search

auth0 / node-jwa

JSON Web Algorithms
http://tools.ietf.org/id/draft-ietf-jose-json-web-algorithms-08.html
MIT License
98 stars 42 forks source link

Switch to maintained b64u package #22

Closed jacobwgillespie closed 6 years ago

jacobwgillespie commented 6 years ago

The base64url package has not been updated since 2016 and currently has a critical issue that prevents TypeScript users from using it with any version of Node other than v6.0.0. This affects both the base64url package and all packages that depend on it, including this one.

This PR updates replaces base64url with b64u, a maintained, API-identical equivalent package. Since the API is identical, this should require no additional changes.

jacobwgillespie commented 6 years ago

b64u only supports Node versions v4+, as the Buffer API from pre-v4 is deprecated as of Node v6. Given that Node v0.12 hit end of life on December 31st, 2016, perhaps it should be dropped from the Travis CI tests.

omsmith commented 6 years ago

Hey - I've removed the dependency on base64url in favour of an inline definition for now so that we can maintain version support.

jacobwgillespie commented 6 years ago

Awesome, thank you!