search

auth0 / node-jwa

JSON Web Algorithms
http://tools.ietf.org/id/draft-ietf-jose-json-web-algorithms-08.html
MIT License
99 stars 41 forks source link

Update base64url dependency version #27

Closed bwendt-mylo closed 6 years ago

bwendt-mylo commented 6 years ago

Resolves https://nodesecurity.io/advisories/658

omsmith commented 6 years ago

I don't believe maintaining this as a dev dependency raises any flags for installs. Do you have evidence to the contrary?

bwendt-mylo commented 6 years ago

No it won't raise any flags for install, but figured it can't hurt to be at the latest version.

omsmith commented 6 years ago

Alright, thanks for looking. As you'll note by the test suite, there is much breakage due to new syntax. I'm open to other changes.

bwendt-mylo commented 6 years ago

Yeah, looks like it's the use of the default function parameters that's breaking the builds. Probably not worth pursuing at the point.

omsmith commented 6 years ago

Going to close for now.

Thanks