search

auth0 / node-jwa

JSON Web Algorithms
http://tools.ietf.org/id/draft-ietf-jose-json-web-algorithms-08.html
MIT License
98 stars 42 forks source link

Allow object for key signing #7

Closed alexandrebodin closed 9 years ago

alexandrebodin commented 9 years ago

This allows using passphrase protection for rsa keys

omsmith commented 9 years ago

You've a typo in the verifier typeof check

(On my phone, commenting on the line directly is hard)

alexandrebodin commented 9 years ago

Thanks!

I have a problem with the version of the crypto api... in node v10.39 the sign method expects a buffer or a string... but in node v0.11.8+ objects are allowed...

omsmith commented 9 years ago

Mind adding a process.version check in the tests or somesuch, so that we can still run the tests in 0.10?

Would either not run the password-protected PEM tests, or would assert that they throw 'Not a buffer'

alexandrebodin commented 9 years ago

On it

omsmith commented 9 years ago

@brianloveswords This LGTM. Would like to publish current master as a patch version before merging this as a minor.

omsmith commented 9 years ago

@brianloveswords FYI, I don't have npm access so I can't action the above

brianloveswords commented 9 years ago

@omsmith added you as co-owner of jws and jwa !