search

auth0 / node-jwks-rsa

A library to retrieve RSA public keys from a JWKS (JSON Web Key Set) endpoint.
MIT License
836 stars 236 forks source link

Dependencies on @types/xxx should be in devDependencies #317

Closed christopheblin closed 2 years ago

christopheblin commented 2 years ago

Describe the problem

in package.json, you have in the dependencies section

"@types/express": "^4.17.13",
"@types/jsonwebtoken": "^8.5.8",

@types/xxx dependencies are usually in devDependencies

Is there a reason for this ?

The (probably unintented) consequence is that my project which uses only fastify has dependencies on express ...

Environment

adamjmcgrath commented 2 years ago

Hi @christopheblin - there's been some back and forth on this. In the end we decided to stick to it in dependencies - See https://github.com/auth0/node-jwks-rsa/pull/80#pullrequestreview-244880314