search

auth0 / node-jws

JSON Web Signatures
http://self-issued.info/docs/draft-ietf-jose-json-web-signature.html
MIT License
709 stars 108 forks source link

When decoding, if JWT payload is not valid it returns null #24

Open dschenkelman opened 9 years ago

hsablonniere commented 9 years ago

Hey, BTW, there's already a "safe" JSON parse : https://github.com/brianloveswords/node-jws/blob/master/lib/verify-stream.js#L14

I have the same problem so I would really like to see this PR merged.

dschenkelman commented 8 years ago

Wow, had forgotten about this PR! @hsablonniere thanks for the suggestion, updated the code.

Just updated to master in case this could still get in. I know it changes behaviors compared to the old one, but is seems more consistent.

Thoughts?

hsablonniere commented 7 years ago

Hey Damian,

Long time no see :-) I don't have any ongoing projects using this. I just took a bit of time to read it and it seems legit.