search

auth0 / node-jws

JSON Web Signatures
http://self-issued.info/docs/draft-ietf-jose-json-web-signature.html
MIT License
709 stars 108 forks source link

Updating base64url to v2.0.0 #58

Closed MarkHerhold closed 8 years ago

MarkHerhold commented 8 years ago

The base64url module changes from 1.x to 2.x only involved a rewrite to TypeScript. It appears that no tests were changed between the versions. Fixes issue #56

omsmith commented 8 years ago

Make it a ^ and you've got yourself a deal

MarkHerhold commented 8 years ago

@omsmith Good to go so long as you squash and merge. :) Thanks!

MarkHerhold commented 8 years ago

@omsmith Thanks! Looking forward to a release. :) Also, #56 can now be closed.

daKuleMune commented 7 years ago

I noted that this change has not yet been reflected in the npm package. Can you verify if this will fix the deprecation warning in node 7? DeprecationWarning: Using Buffer without 'new' will soon stop working. Use 'new Buffer()', or preferably 'Buffer.from()', 'Buffer.allocUnsafe()' or 'Buffer.alloc()' instead. at Buffer (buffer.js:79:13) at base64url (/project/node_modules/base64url/index.js:41:21) at jwsSecuredInput (/project/node_modules/jws/lib/sign-stream.js:11:23) ... etc