Closed tomauth0 closed 3 years ago
The existing methods of ID generation are not cryptographically secure. This PR introduces the id-generation lib - a lightweight lib for generating suitably random IDs with a given dictionary. Utils.js updated to make use of this lib
Also used the opportunity to cleanup some of the utils file - swapping out vars and removing some unneeded syntax
https://github.com/auth0/node-samlp/issues/111
Unit tests added for ID length and dictionary memebership
master
Description
The existing methods of ID generation are not cryptographically secure. This PR introduces the id-generation lib - a lightweight lib for generating suitably random IDs with a given dictionary. Utils.js updated to make use of this lib
Also used the opportunity to cleanup some of the utils file - swapping out vars and removing some unneeded syntax
References
https://github.com/auth0/node-samlp/issues/111
Testing
Unit tests added for ID length and dictionary memebership
Checklist
master