search

auth0 / node-xml-encryption

W3C XML Encryption implementation for node.js (http://www.w3.org/TR/xmlenc-core/)
MIT License
37 stars 57 forks source link

feat: sinon is a dev dependency #71

Closed FauxFaux closed 4 years ago

FauxFaux commented 4 years ago

Description

sinon, a mocking framework used in tests, is listed as a production dependency. sinon is bigger than all of the rest of the code and tests and dependencies combined, so it's a shame shipping it as a production dependency.

Change it to a dev dependency, only available for tests.

Testing

faux@astoria:~/clone/node-xml-encryption% g grep sinon | fgrep -v package-lock
package.json:    "sinon": "^9.0.2"
test/xmlenc.encryptedkey.js:var sinon = require('sinon');
test/xmlenc.encryptedkey.js:    consoleSpy = sinon.spy(console, 'warn');
gkwang commented 4 years ago

@FauxFaux Can you kindly sign the commit since it's required for us to merge the change.

FauxFaux commented 4 years ago

Third time lucky!