Replace node-forge by native node crypto.

forty commented 3 years ago

This requires dropping support for node 8, which is probably fine since node 8 is EoL since December 31, 2019.

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Drop node-forge (which is a huge dep), use native nodejs crypto.

References

About node 8 support https://blog.risingstack.com/update-nodejs-8-end-of-life-no-support/

Node Crypto https://nodejs.org/api/crypto.html#crypto_crypto_publicencrypt_key_buffer https://nodejs.org/api/crypto.html#crypto_crypto_privatedecrypt_privatekey_buffer

Testing

I updated first the encryption part, ran the tests (it was fine) then the decryption part (tests still fine). This made sure the new encryption works well with the

Checklist

[x] I have added documentation for new/changed functionality in this PR or in auth0.com/docs
[x] All active GitHub checks for tests, formatting, and security are passing
[x] The correct base branch is being used, if not master

forty commented 3 years ago

Hello maintainers! Any interest in having this merged?

forty commented 2 years ago

This PR would also fix https://github.com/auth0/node-xml-encryption/pull/93 :)

@gkwang @esarafianou are you still working on this project ?

esarafianou commented 2 years ago

Hi @forty, seems like we missed your previous messages. I'll have the PR reviewed within the week.

esarafianou commented 2 years ago

@forty could you address @panva's feedback? I'll then approve, merge and create a release PR.

forty commented 2 years ago

Thanks for the comments @panva !

@esarafianou I've just updated the PR.

Thanks!

auth0 / node-xml-encryption