auth0 / omniauth-auth0

OmniAuth strategy to login with Auth0
MIT License
125 stars 67 forks source link

fix for custom domain #72

Closed wqsaali closed 5 years ago

wqsaali commented 5 years ago

Changes

If your application issues an /authorize request with audience=https://login.northwind.com/userinfo, the server will return a Service not found: https://login.northwind.com/userinfo error. This is because even if you set a custom domain the API identifier for the /userinfo endpoint remains https://{YOUR_ORIGINAL_AUTH0_DOMAIN}/userinfo.

To fix this your app should instead use audience=https://{YOUR_ORIGINAL_AUTH0_DOMAIN}/userinfo. You can also remove this audience=[...]/userinfo parameter altogether if your application is flagged as OIDC-Conformant in the OAuth2 tab of the application's Advanced Settings.

References

Testing

Checklist

joshcanhelp commented 5 years ago

@wqsaali - This is great, thank you for the quick PR here. Let me think through how this works and make sure we're handling this the right way.

joshcanhelp commented 5 years ago

@wqsaali - Were you able to get this working or do we still need to investigate a fix here? Will be releasing a new version in the near future and would like to get this in, if needed. Happy to help investigate if you have repro steps for it failing.

Thank you 🙌

joshcanhelp commented 5 years ago

Closed for no activity.