search

auth0 / passport-windowsauth

Windows Authentication strategy for Passport.js
MIT License
178 stars 54 forks source link

ldapjs issue #12

Closed dutch closed 10 years ago

dutch commented 10 years ago

Thanks for a fantastic passport.js plugin :-)

Question: Is there a reason you're using a personal fork of ldapjs instead of the original project? Your version has a dependency on an old version of buffertools which unfortunately cannot be built with VS2013.

I've notified buffertools of the fix, and they've made it work under VS2013 in version 2.0.1, but your module still points to the old version. Is there any chance you could bump to the latest ldapjs?

Thanks.

jfromaniello commented 10 years ago

Hi @dutch, no there is no reason, our fork has a fix for an issue but this fix has already been merge to master, so there is no reason to point to our fork.

rickdailey commented 10 years ago

Any progress on this? We have the same issue where this project is referencing your branch of ldapjs instead of master.

jfromaniello commented 10 years ago

Thanks for the heads up, published as v0.2.0.

Best regards,