search

auth0 / passport-windowsauth

Windows Authentication strategy for Passport.js
MIT License
178 stars 54 forks source link

Pass socket timeout options to ldap.createClient #44

Closed heikkipora closed 7 years ago

heikkipora commented 8 years ago

The default ldap client socket timeout options (i.e. infinity) are really not well suited for real-world environments, so allow the caller to override them

mweibel commented 8 years ago

Totally agree. I also don't understand why not all options are passed. As it's scoped in passport-windowsauth anyway, we could just pass options. I encountered a hard to reproduce issue and I suspect it has to do with the timeout and/or the LdapValidator also not passing the reconnect flag to it. I'm trying now a fix similar to this, but with passing even more options: https://github.com/auth0/passport-windowsauth/compare/master...mweibel:fix/reconnect?expand=1

I also don't see the point of the LdapValidator not reusing the client created by LdapLookup.. Is there any reason for that?

heikkipora commented 7 years ago

Being able to set timeout (and other) options to the LDAP client would be really really important for me :-) ping @jfromaniello

Let me know if there's anything I could do to help with getting this and (#45) merged.

jfromaniello commented 7 years ago

Thank you for your changes. I think #45 already have your commits, so we are good to go.