auth0 / repo-supervisor

Scan your code for security misconfiguration, search for passwords and secrets. :mag:
MIT License
637 stars 88 forks source link

fix missing zip package in dockerfile #42

Closed eliottthomas1 closed 4 years ago

eliottthomas1 commented 4 years ago

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Fix for missing Zip package in Dockerfile. Docker image successfully builds with this package included.

References

https://github.com/auth0/repo-supervisor/issues/41

Testing

Build the docker image with the version 3.0.0 changes and include the Zip package as i have done.

Checklist

radekk commented 4 years ago

@eliottthomas1 one more thing, would it be possible to GPG sign this commit? otherwise I can't merge it since we blocked merging non-signed commits and it's enforced on the repository level. You can rebase your branch to sign already commited changes and push force that.

References:

eliottthomas1 commented 4 years ago

@radekk yep sure will sign and recommit

radekk commented 4 years ago

Perfect! Thanks, it looks good now. Let me merge that.

radekk commented 4 years ago

I just fixed the latest commit in the master branch. I merged this PR using squash method and it didn't authored this commit with your details which I didn't like. I don't want to get credits for your work. It seems to be an issue how github handles that: https://github.com/isaacs/github/issues/1368#issuecomment-595111126

It should be good right now and you're listed as a contributor 👍