auth0 / repo-supervisor

Scan your code for security misconfiguration, search for passwords and secrets. :mag:
MIT License
637 stars 88 forks source link

Add support for yaml files #43

Closed eliottthomas1 closed 4 years ago

eliottthomas1 commented 4 years ago

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Adds support for yaml file type. Uses the js-yaml library to parse yaml then returns unique values of all nested objects. https://www.npmjs.com/package/js-yaml

The js-yaml safeLoad method is also safe for untrusted data.

Testing

Pass any path containing a yaml file when running the app

Checklist

eliottthomas1 commented 4 years ago

ah I forgot to sign these commits, will do that

radekk commented 4 years ago

Tests look good, thanks for implementing those @eliottthomas1 👍 After there is a limit set for this recursive function we can merge that 🎉

radekk commented 4 years ago

@eliottthomas1 seems like I can't merge it because the latest commit is not signed. Re-sign them please and push force whenever you have a time and I will merge this PR. Thanks once again 👍

image

eliottthomas1 commented 4 years ago

@radekk sorry got a bit mixed up with unsigned merge commits but should be good now to re-approve 🎉