search

auth0 / symfony

Symfony SDK for Auth0 Authentication and Management APIs.
MIT License
124 stars 74 forks source link

Allow symfony-7 in composer.json #188

Closed mkilmanas closed 4 months ago

mkilmanas commented 9 months ago

Changes

This is simply allowing Symfony 7 in composer.json - could not find any problems or incompatibilities at this point.

References

182

Testing

Attempted to install this bundle on a small Symfony project and perform JWT authentication. Other use-cases should be verified.

Maybe instead of merging to main branch, this should be "quarantined" in a dedicated branch (e.g. symfony7) of this main repository - that way other people would be able to install this version via composer by requiring auth0/symfony: dev-symfony7 and then test on their applications and their use-cases?

[ ] This change adds test coverage

[x] This change has been tested on the latest version of Symfony

Checklist

[x] I have read the Auth0 general contribution guidelines

[x] I have read the Auth0 Code of Conduct

[x] All existing and new tests complete without errors

evansims commented 9 months ago

Hey @mkilmanas thanks a lot for contributing this; our team is at an offsite this week so my bandwidth is a little limited, but I'll take a look at this as soon as I'm back at my desk next week. Appreciate it!

mkilmanas commented 9 months ago

@evansims any chance to review this anytime soon? auth0/symfony is now the only remaining dependency blocking us from migrating to Symfony 7 on our projects

mkilmanas commented 8 months ago

Hey @evansims , is there anything happening at all? It's been over a month and no update. Do we need to start considering a fork of this repo to have things moving? Or how else can we get support for up-to-date versions of Symfony?

gusdeboer commented 8 months ago

Will be needing this soon if our company was to implement Auth0

ip512 commented 8 months ago

@evansims do you think this PR could be merged shortly ? This could be a showstopper in the adaption of auth0 for some projects if this SDK is not compatible with sf7

mkilmanas commented 8 months ago

We have run out of patience and made a fork of this bundle -> https://packagist.org/packages/elvi/auth0-symfony

We will aim to maintain compatibility/updates as soon as they come to this official bundle, but also we will try to merge fixes/updates more proactively. No promises/guarantees though - still it's an open-source thing.

@gusdeboer @ip512 - feel free to give it a try (and any feedback welcome)