Fix secrets panel load and add run suffix as option

auth0 / webtask-widget

[BETA] Widget that can be embedded in websites to allow transparent creation of extension points or urls.

MIT License

10 stars 2 forks source link

Fix secrets panel load and add run suffix as option #39

Closed jcenturion closed 8 years ago

ggoodman commented 8 years ago

Why is the secrets fix that you propose needed? Is it because the secrets panel gets a reference to a secrets object that changes later on? If that is the case, a better approach would be to use the componentWillReceiveProps lifecycle hook, wouldn't it?

jcenturion commented 8 years ago

@ggoodman already modified the code

ggoodman commented 8 years ago

LGTM. Please bump version then good to merge.

ggoodman commented 8 years ago

It was already bumped. I missed it. Merging.