authcrunch / authcrunch.github.io

Documentation for Caddy v2 Auth Portal and Authorize Plugins.
79 stars 32 forks source link

Incorrect crypto key statement in oauth authproxy example #10

Closed sharon-tickell closed 2 years ago

sharon-tickell commented 2 years ago

In the Caddyfile example at https://github.com/authp/authp.github.io/blob/main/assets/conf/oauth/authproxy/Caddyfile, you have the line crypto key sign-verify {env.JWT_SHARED_KEY} in both the authentication portal block and the authorization portal block.

If I'm reading the docs at https://authp.github.io/docs/authenticate/auth-cookie correctly, shouldn't that be sign-verify as written in the authentication portal block, but just verify in the authorization policy?

greenpau commented 2 years ago

@sharon-tickell , thank you for the issue! 👍 will update it by The EOW.

greenpau commented 2 years ago

Updated docs. Pending release.