Case-insensitive wallet matching - Githubissues

authenticvision / digitalsoul

MetaAnchor-Framework for self-hosting

MIT License

2 stars 0 forks source link

Case-insensitive wallet matching #64

Closed tbergmueller closed 11 months ago

tbergmueller commented 11 months ago

Currently, wallet-addresses are matched in a case-sensitive way throughout the framework. Hence, if a user once uses the same wallet address, but with different writing, it would be interpreted as different wallets by the framework. This is in particular problematic

with the landing page (decision whether to claim or already current owner)
contract-ownership
Authorization, JWT, ...

This is in particular problematic, because wallet-addresses use Capitals for checksums

Options:

Just use lower-case wallets throughout the studio and database (this allows for robust coding, we don't need to be concious here)
In code, refactor everything to case-insensitive matches. This is verry error-prone, as it may easily be overlooked in new features.

tbergmueller commented 11 months ago

Was fixed with #66