authgear / authgear-sdk-js

Authgear authentication SDK for Single Page Applications (SPA) and JavaScript websites
https://www.authgear.com/
Other
5 stars 18 forks source link

open URL from SDK should use the domain got from server #248

Closed fungc-io closed 1 year ago

fungc-io commented 1 year ago

After applying custom domain The authentication flow still work without changing the endpoint, because it uses the domain retrieve from the server.

However the open settings page method is still using the endpoint. It will be great if it use the custom domain automatically, so it is not necessary for the user to update the app.

joyzoursky commented 1 year ago

Experiencing this issue when testing on version update for an exisitng app.

I think this is a should-fix bug more than enhancement issue, as it is quite often that end-user will not always keep their apps updated, then on old version they will see the invalid redirect URI error from authgear.

louischan-oursky commented 1 year ago
fungc-io commented 1 year ago

tested, all is good