authgear / authgear-server

Open source alternative to Auth0 / Firebase Auth
https://www.authgear.com
Apache License 2.0
72 stars 29 forks source link

Change navigation uri in OnboardingRedirect #4354

Closed toshinari123 closed 4 days ago

toshinari123 commented 1 week ago

4345

https://linear.app/authgear/issue/DEV-1422/redirect-new-users-to-onboarding-survey-after-signing-up

demo: (note my local branch was not up to date, so company name was not filled in project name)

https://github.com/authgear/authgear-server/assets/68701054/06807bdc-f248-44e6-a22a-59d3d9130ce6

toshinari123 commented 4 days ago

During my local testing, if a new user tries to access accounts.portal.localhost and sign up, they will be redirected to account settings, and cannot go to the portal. Is this a concern?

tung2744 commented 4 days ago

Do you mean going to accounts.portal.localhost directly? If yes, it is expected that it won't back to portal, because the login is not triggered by portal.

tung2744 commented 4 days ago

@toshinari123 Sorry one problem remaining. When testing together with https://github.com/authgear/authgear-server/pull/4343#pullrequestreview-2137443329 I found that viewer.isOnboardingSurveyCompleted is not updated after I completed the survey, because the query isn't refetching. Therefore please refetch the viewer query after updateCustAttrHook called.