authgear / authgear-server

Open source alternative to Auth0 / Firebase Auth
https://www.authgear.com
Apache License 2.0
72 stars 29 forks source link

Implement bot protection in auth flow handlers #4358

Closed pkong-ds closed 4 days ago

pkong-ds commented 1 week ago

Blocked by

Notes

This PR only address 3 out of 4 items of DEV-1413

Why? - to prevent conflict of 4th point with another PR #4372

pkong-ds commented 1 week ago

@louischan-oursky Can I have you attention to my current way of injecting config.AuthenticationFlow inside Service But I feel like there is a better way, any thoughts? :Adore:

pkong-ds commented 1 week ago

@louischan-oursky free to go through the 2 FIXME commits with me later? 🙏 Not sure which branch should these intent point to for captcha requirement checking

pkong-ds commented 5 days ago

@louischan-oursky this should be ready for review :adore:

Note: Quick search seem no test on the 3 api handlers; so did not add tests for extra bot_protection fields. Please advise if otherwise 👍

pkong-ds commented 4 days ago

@louischan-oursky updated, thanks! Added 2 commits, starting from f53fa58