Feature flag for template customization

authgear / authgear-server

Open source alternative to Auth0 / Firebase Auth

https://www.authgear.com

Apache License 2.0

72 stars 29 forks source link

Feature flag for template customization #4385

Closed elise-ng closed 4 days ago

elise-ng commented 1 week ago

Ref DEV-1302

tested server change by adding test case.

tested ui by setting the flag in local fs var/authgear.features.yaml:

messaging:
  template_customization_disabled: true

portal screenshot:

https://github.com/authgear/authgear-server/assets/11769136/bbe2a4e5-637e-4f6f-a8d1-d6f1c3fe23fc

elise-ng commented 1 week ago

@louischan-oursky i assume "overriding" the MatchResource methods would be fine & we can treat CustomizableXXX as XXX type during render because it will only use FindResources and ViewResourceswhich does not require separate behavior

lmk if there is better golang tricks for this

elise-ng commented 5 days ago

@louischan-oursky i have tested can't update html or txt even if user override readOnly from ui; however user will still be able to update translations.json (email subject field), should we change that descriptor as well or would there be side-effect?

elise-ng commented 5 days ago

from discussion:

change pkg/util/template/translation.go, processAppTranslationData if feature flag on, do not save keys with pattern email.***.subject

elise-ng commented 4 days ago

@louischan-oursky updated, plz check again 🙏