search

authgear / authgear-server

Open source alternative to Auth0 / Firebase Auth
https://www.authgear.com
Apache License 2.0
81 stars 37 forks source link

Update brand logo margin #4767

Closed pkong-ds closed 4 days ago

pkong-ds commented 5 days ago

ref DEV-2016

portal height slider in next PR.

Preview

https://github.com/user-attachments/assets/30eca53a-eb5a-4543-9bfd-62aa99981429

pkong-ds commented 4 days ago

Updated thanks!

pkong-ds commented 4 days ago

Thanks 🙏

louischan-oursky commented 4 days ago

@pkong-ds I added 3 commits.

pkong-ds commented 4 days ago

@louischan-oursky I did not use gap in screen-logo-layout because it's not the only place that uses brand logo.

I believe __direct_access and __settings_header both use it. If the margin is removed without adding gap to these 2 files, the existing UI will probably break.

Maybe we should add gap to those 2, or keep margin bottom?

pkong-ds commented 4 days ago

Also, curious, is object contain really necessary with flex?

pkong-ds commented 4 days ago

Per offline discussion

__direct_access and __settings_header both use it

__direct_access - Fixed by @louischan-oursky in cf53deb, 42ef98b __settings_header - to be removed in PR #4770

is object contain really necessary

Turns out it was a bug previously, @louischan-oursky helped fix it in b5224dc