search

authomatic / chromedriver_installer

ChromeDriver installer for Python
15 stars 34 forks source link

Fix Chrome Version Number Regex Check #12

Closed kiwimatt001 closed 5 years ago

kiwimatt001 commented 5 years ago

Chrome Driver versions have moved from a #.# to a #.#.#.# number format in newer versions. A check in this setup script was throwing an Invalid Chromedriver-version error an exception incorrectly.

Error: Exception: Invalid --chromedriver-version=76.0.3809.25! Must match /^\d+.\d+$/

This change fixes that error.

I've tested the new regex in an online regex checker and it matches both the new version string and the old (i.e. 76.0.3809.25 matches, and 2.47 matches)

kiwimatt001 commented 5 years ago

i'll reopen this when i have time to fix the test