authorblues / bizhawk-shuffler-2

A script to randomly shuffle between games played in Bizhawk, with plugins to enhance the experience
MIT License
58 stars 21 forks source link

Make dump() more robust #24

Closed kalimag closed 3 years ago

kalimag commented 3 years ago

This PR modifies dump() to escape string values and make key/value handling consistent.

Main differences are:

This should not make any practical difference for the shuffler as-is, because all table keys are known strings and all string values currently found in the config are limited by rules for file names. It would only be relevant to future features and external plugins.

authorblues commented 3 years ago

I like it. I hadn't considered that plugins would really demand a bit more scrutiny from my dump() method.