authorblues / bizhawk-shuffler-2

A script to randomly shuffle between games played in Bizhawk, with plugins to enhance the experience
MIT License
58 stars 21 forks source link

checkversion can return incorrect results on future versions #44

Closed kalimag closed 2 years ago

kalimag commented 2 years ago

The checkversion method returns false if any component of the current version is lower than the required version. That means 2.7.0 is considered lower than 2.6.1, because 0 < 1.

Currently the only effect is that the INCOMPATIBLE_BIZHAWK_VERSION check does not warn about 2.7 incompatibility and a confusing/misleading warning about upgrading to MIN_BIZHAWK_VERSION is shown instead.

https://github.com/authorblues/bizhawk-shuffler-2/blob/7545ddd025e66537fd3b6f1549c7665657f9a7c2/shuffler.lua#L346-L365

Environment: