search

authorjapps / zerocode-hello-world

Zerocode YAML and JSON based declarative steps hello world rest api testing example - soap, database
https://github.com/authorjapps/zerocode
MIT License
18 stars 36 forks source link

ISSUE-23 #Fixed deprecated import #34

Closed Shilpa-Perera closed 1 month ago

Shilpa-Perera commented 1 month ago

SSlContextBuilder has been deprecated Solution change org.apache.http.conn.ssl.SSLContexts to org.apache.http.ssl.SSLContexts in CustomHttpClient.java class

Additionally some typos in the comments of CustomHttpClient.java class was fixed. @authorjapps could you review ?

Shilpa-Perera commented 1 month ago

@nirmalchandra could you please review ?

nirmalchandra commented 1 month ago

@nirmalchandra could you please review ?

yep, thanks. Looks fine to me. You can merge it now.

Also can you rerun your scenario to check all working as exepcted?

Shilpa-Perera commented 1 month ago

Also can you rerun your scenario to check all working as exepcted?

@nirmalchandra @authorjapps I reran all the tests and all working as expected. Since I do not have the write access to this repo I can not merge the PR. Could you give me access?

nirmalchandra commented 1 month ago

Also can you rerun your scenario to check all working as exepcted?

@nirmalchandra @authorjapps I reran all the tests and all working as expected. Since I do not have the write access to this repo I can not merge the PR. Could you give me access?

Merged now.

That's wierd, let me add you to the repo as collaborator now.

nirmalchandra commented 1 month ago

Also can you rerun your scenario to check all working as exepcted?

@nirmalchandra @authorjapps I reran all the tests and all working as expected. Since I do not have the write access to this repo I can not merge the PR. Could you give me access?

You can now join via this link: https://github.com/authorjapps/zerocode-hello-world/invitations

Can you try bumping the version here in the POM to the latest and see all tests are working?

Latest:

1.3.43

Current(very old):

1.3.23

You may have to raise a new PR for this.