authorly / interapptive

Authorly mobile
1 stars 0 forks source link

Use physical distance for swipe tolerence #357

Closed whitman closed 10 years ago

whitman commented 10 years ago

Currently, we use pixels for swipe tolerence. We should use physical distance instead.

minggo commented 10 years ago

Can reproduce it with iPhone4 retina simulator. Right?

whitman commented 10 years ago

@minggo Yes

whitman commented 10 years ago

As a note to reproduce, it can be shown by clicking the mouse on page except the first page. When a click is made on the page, it will turn the page back.

whitman commented 10 years ago

Error when running on Galaxy Tab 10.2:

unnamed

minggo commented 10 years ago

I sent a commit to fix the crash.

waseem commented 10 years ago

This was deployed to staging.

whitman commented 10 years ago

Note: needs to be tested on follow devices

The following are expected behaviors

@waseem, can you try on your iPad 2? @Eaven can test on his iPhone, him and I can both test on Android phones & tablets.

waseem commented 10 years ago

It works fine on my iPad 2.

Eaven commented 10 years ago

verified

waseem commented 10 years ago

Deployed with 2.1.1

Eaven commented 10 years ago

Verified.