search

authpass / biometric_storage

Flutter plugin to store data behind biometric authentication (ie. fingerprint)
https://pub.dev/packages/biometric_storage
MIT License
184 stars 107 forks source link

biometric_storage does not build with Java 21 #117

Closed connyduck closed 5 months ago

connyduck commented 5 months ago

We are upgrading our project to Java 21 and the only package that is causing issues is biometric_storage. Yes, a possible workaround is to have both JDK 17 and 21 installed via gradle toolchains, but it would be very nice to need only one, e.g. for CI/CD. Please check if you can make biometric_storage work with Java 17 and up instead of explicitly requiring 17.

hpoul commented 5 months ago

since the code is all kotlin, this should be a pretty minor change.. feel free to provide a PR, I should be able to review it pretty quickly..

hpoul commented 5 months ago

thanks, i actually haven't tested it (yet), maybe you could give 5.1.0-rc.4 a try. 😅

connyduck commented 4 months ago

@hpoul 5.1.0-rc.4 works fine in a Java 21 only and a 17 only project now! When will 5.1.0 be released?

GuvanchBayryyyev commented 3 months ago

it still gives me an error Execution failed for task ':biometric_storage:compileReleaseJavaWithJavac'. > error: invalid source release: 17