save macos keys in keychain under app.bundle.id

authpass / biometric_storage

Flutter plugin to store data behind biometric authentication (ie. fingerprint)

https://pub.dev/packages/biometric_storage

MIT License

171 stars 101 forks source link

save macos keys in keychain under app.bundle.id #44

Open zeroflaw opened 2 years ago

zeroflaw commented 2 years ago

Issue: https://github.com/authpass/biometric_storage/issues/43#issue-1031615608

Removing keys in macOS is not obvious because they are not saved under the app.bundle.id. This pull request fixes that.

hpoul commented 2 years ago

thanks for the PR, but this is a pretty heavy breaking change.. i think it would be better to allow configuration of the service name? (maybe keeping the default to flutter_biometric_storage 🤔️)

CLAassistant commented 1 year ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}