authpass / biometric_storage

Flutter plugin to store data behind biometric authentication (ie. fingerprint)
https://pub.dev/packages/biometric_storage
MIT License
184 stars 107 forks source link

⚡️ Upgrade a native dependency that blocks running the package with other apps #96

Closed YazeedAlKhalaf closed 6 months ago

YazeedAlKhalaf commented 1 year ago

This PR updates the fragment dependency to latest stable version as of today. The fragment dependency depends on the lifecycle dependency which caused some issue with version differences, now those issues are gone.

Here is the version that updated the dependency which is lifecycle from 2.3.1 to 2.5.1

https://developer.android.com/jetpack/androidx/releases/fragment#1.5.1

Error

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:check[REDACTED]DebugDuplicateClasses'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable
   > Duplicate class androidx.lifecycle.ViewModelLazy found in modules jetified-lifecycle-viewmodel-ktx-2.3.1-runtime (androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1) and lifecycle-viewmodel-2.5.1-runtime (androidx.lifecycle:lifecycle-viewmodel:2.5.1)
     Duplicate class androidx.lifecycle.ViewTreeViewModelKt found in modules jetified-lifecycle-viewmodel-ktx-2.3.1-runtime (androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1) and lifecycle-viewmodel-2.5.1-runtime (androidx.lifecycle:lifecycle-viewmodel:2.5.1)

     Go to the documentation to learn how to <a href="d.android.com/r/tools/classpath-sync-errors">Fix dependency resolution errors</a>.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1m 20s
CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

YazeedAlKhalaf commented 1 year ago

@hpoul Kindly review this PR, it is important so that conflicts don't arise when people use this package with other packages.

YazeedAlKhalaf commented 1 year ago

Thank you @aelahmar for your support!

bilaldbank commented 1 year ago

@YazeedAlKhalaf good contribution to a useful package! Waiting for this PR to be merged

hatch01 commented 1 year ago

Will this PR be merged @hpoul @luckyrat ?